Fix ActiveRecordRelations compiler to dedup #all #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwise-aiden
force-pushed
the
ba-fix-arr-all
branch
from
f59f79f
to
5aa266f
Compare
bitwise-aiden
force-pushed
the
ba-fix-arr-all
branch
from
5aa266f
to
321345b
Compare
egiurleo
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Rails head has been updated to include
#allunderActiveRecord::QueryMethods(source).Implementation
I had tried to update the
QUERY_METHODSconstant to remove the intersection withActiveRecord::AssociationRelation.instance_methodsas that is where all is originally coming from, but this was over zealous causing a bunch of errors.The option I've gone with is to update the ones removed as "private api" since they overlap with what is done in Rails:
tapioca/lib/tapioca/dsl/compilers/active_record_relations.rb
Line 194 in d652d57
Tests
Tested against rails head.